From: Johannes Sixt Date: Tue, 05 Jun 2007 10:40:50 GMT Subject: Re: [PATCH 1/2] git-submodule: move cloning into a separate function Message-ID: <46653DB2.997A3ABD@eudaptics.com> In-Reply-To: <11810357522478-git-send-email-hjemli@gmail.com> Lars Hjemli wrote: > + module_clone "$path" "$url" || exit $? Minor nit: The idiom that is commonly used in situations like this (see other git-* shell scripts): module_clone "$path" "$url" || exit because exit without argument uses the code of the last command executed. -- Hannes