git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-send-email: default value for "From:" field.

From
QTQuy Tonthat <qtonthat@gmail.com>
Date
Jan 19, 2007, 01:14 UTC
Message-ID
<45B01B82.9050707@gmail.com>
In-Reply-To
<45AFDAEA.607@freescale.com>
Timur Tabi wrote:
Show 25 quoted lines
> Quy Tonthat wrote:
>> If user hits enter at the prompt for
>> "Who should the emails appear to be from?",
>> the value for "From:" field was emptied instead of GIT_COMMITER_IDENT.
>>
>> Signed-off-by: Quy Tonthat <qtonthat@gmail.com>
>> ---
>> It seems the original code assumes readline to accept
>> an extra argument for default value. I don't remember I ever encountered
>> that feature from readline. Is there anything like that out there ?
> 
> I was thinking the same thing.  Almost every call to readline() in
> git-send-email is like that, so could your patch below could be expanded
> to include the other instances?
> 
>         $_ = $term->readline("Who should the emails be sent to? ",
>                         "");
> 
>         $_ = $term->readline("What subject should the emails start with? ",
>                 $initial_subject);
> 
>         $_= $term->readline("Message-ID to be used as In-Reply-To for
> the first email? ",
>                 $initial_reply_to);
> 

It is correct to expand the fix to other instances, but that won't practically change anything at run time (All those "defaults" are empty when passed to readline). I don't normally change somebody else's codes just for the sake of correctness or styles. Quy

Previous: Timur Tabi
Message 4 of 4 in “git-1.4.4.3, also 1.5.0rc0: send-email gets empty From:”
  1. Horst H. von BrandDec 27, 2006
  2. git-send-email: default value for "From:" field.Quy Tonthat, Dec 27, 2006
  3. Timur TabiJan 18, 2007
  4. Quy TonthatJan 19, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.