Re: [PATCH] git-send-email: default value for "From:" field.

From: Timur Tabi <timur@freescale.com>
Date: Jan 18, 2007, 20:39 UTC
Message-ID: <45AFDAEA.607@freescale.com>
In-Reply-To: <45928035.6000605@gmail.com>

Quy Tonthat wrote:

Show 9 quoted lines

> If user hits enter at the prompt for
> "Who should the emails appear to be from?",
> the value for "From:" field was emptied instead of GIT_COMMITER_IDENT.
> 
> Signed-off-by: Quy Tonthat <qtonthat@gmail.com>
> ---
> It seems the original code assumes readline to accept
> an extra argument for default value. I don't remember I ever encountered
> that feature from readline. Is there anything like that out there ?

I was thinking the same thing. Almost every call to readline() in git-send-email is like that, so could your patch below could be expanded to include the other instances?

         $_ = $term->readline("Who should the emails be sent to? ",
                         "");

         $_ = $term->readline("What subject should the emails start with? ",
                 $initial_subject);

         $_= $term->readline("Message-ID to be used as In-Reply-To for the first 
email? ",
                 $initial_reply_to);

-- 
Timur Tabi
Linux Kernel Developer @ Freescale