git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-svn: fix dcommit losing changes when out-of-date from svn

From
Steven Grimm <koreth@midwinter.com>
Date
Nov 9, 2006, 19:30 UTC
Message-ID
<455381C7.8080207@midwinter.com>
In-Reply-To
<7vfyctkki5.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
Show 5 quoted lines
> Steven, I do not interact with real svn repository myself so I
> can only judge from the test in this patch and Steven's test
> case, so it would be more assuring for me if you can confirm it
> fixes the issue for you.
>

It seems to; I can't make the problem happen any more. I am slightly concerned -- but I don't know libsvn well enough to say for sure -- that this doesn't actually *eliminate* the problem, but rather tightens the window of opportunity down to some very small amount of time. Which is certainly an improvement, of course!

Maybe only Eric can answer this, but from a cursory inspection, it doesn't look like it actually locks the modified files before generating the patch to apply. Is there still a possibility of losing a change that hits the svn repository in the middle of git-svn dcommit running? Or does locking happen implicitly somewhere I'm not seeing? (Again, I haven't combed the code deeply, so it's entirely possible I've missed something.)

-Steve
Previous: Eric WongNext: Eric Wong
Message 7 of 9 in “git-svn can lose changes silently”
  1. Steven GrimmNov 9, 2006
  2. Seth FalconNov 9, 2006
  3. git-svn: fix dcommit losing changes when out-of-date from svnEric Wong, Nov 9, 2006
  4. Junio C HamanoNov 9, 2006
  5. Seth FalconNov 9, 2006
  6. Eric WongNov 9, 2006
  7. Steven GrimmNov 9, 2006
  8. Eric WongNov 9, 2006
  9. Steven GrimmNov 9, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.