git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-svn: fix dcommit losing changes when out-of-date from svn

From
EWEric Wong <normalperson@yhbt.net>
Date
Nov 9, 2006, 19:22 UTC
Message-ID
<20061109192200.GA3604@localdomain>
In-Reply-To
<m2r6wcy0t0.fsf@ziti.local>
Seth Falcon <sethfalcon@gmail.com> wrote:
Show 15 quoted lines
> Junio C Hamano <junkio@cox.net> writes:
> > Eric Wong <normalperson@yhbt.net> writes:
> >
> >> There was a bug in dcommit (and commit-diff) which caused deltas
> >> to be generated against the latest version of the changed file
> >> in a repository, and not the revision we are diffing (the tree)
> >> against locally.
> >>
> >> This bug can cause recent changes to the svn repository to be
> >> silently clobbered by git-svn if our repository is out-of-date.
> 
> Eric, with this patch, is a dcommit operation as safe as a regular svn
> commit from an svn working copy?  That is, the commit will abort if
> the svn repository has changes that your git-svn/git repo hasn't yet
> seen?  I'm pretty sure the answer is yes, but I'd like to be sure :-)

Yes, this is as safe as a regular svn commit from a working copy. Transactions will abort if there are conflicts in the files being committed.

Previous: Seth FalconNext: Steven Grimm
Message 6 of 9 in “git-svn can lose changes silently”
  1. Steven GrimmNov 9, 2006
  2. Seth FalconNov 9, 2006
  3. git-svn: fix dcommit losing changes when out-of-date from svnEric Wong, Nov 9, 2006
  4. Junio C HamanoNov 9, 2006
  5. Seth FalconNov 9, 2006
  6. Eric WongNov 9, 2006
  7. Steven GrimmNov 9, 2006
  8. Eric WongNov 9, 2006
  9. Steven GrimmNov 9, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.