Re: [PATCH] git.c: Re-introduce sane error messages on missing commands.

From: Andreas Ericsson <ae@op5.se>
Date: Jun 28, 2006, 08:13 UTC
Message-ID: <44A23A38.3090206@op5.se>
In-Reply-To: <7vpsgu6wba.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 12 quoted lines

> Andreas Ericsson <ae@op5.se> writes:
> 
> 
>>Somewhere in the alias handling git turned hostile on fat fingers:
>>
>>	$ git showbranch
>>	Failed to run command '': Is a directory
> 
> 
> Does not happen here (nor on Cygwin 1.4.1.rc1).  Care to help
> reproducing it?
>

Here's the complete procedure I used:

	$ git pull && make; # works ok
	$ make strip install; # works ok
	$ git showbranch
	Failed to run command '': Is a directory
	(confusion and puzzlement...)
	$ git checkout master; git reset --hard master; # works ok
	$ git pull; # gets nothing (I try stupid things first ;p)
	$ make clean install; # works ok
	$ git showbranch
	Failed to run command '': Is a directory
	$ git --version
	git version 1.4.1.rc1.g1ef9

It's reliably reproducible here. Notable though is that I have no .git/config in my git.git clone and no ~/.gitconfig (or ~/.gitrc or whatever), so the handle_alias() function never finds a config file to look for aliases in.

Either way, removing the variable "char git_command[MAX_PATH + 1];" from git.c:main() is correct since it's never used for anything but printing the (erroneous) error message above.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231