git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git.c: Re-introduce sane error messages on missing commands.

From
MRMarco Roeland <marco.roeland@xs4all.nl>
Date
Jun 28, 2006, 12:00 UTC
Message-ID
<20060628120044.GA3228@fiberbit.xs4all.nl>
In-Reply-To
<Pine.LNX.4.63.0606281240480.29667@wbgn013.biozentrum.uni-wuerzburg.de>
On Wednesday June 28th 2006 Johannes Schindelin wrote:
Show 6 quoted lines
> [PATCH] save errno in handle_alias()
> 
> git.c:main() relies on the value of errno being set by the last attempt to 
> execute the command. However, if something goes awry in handle_alias(), 
> that assumption is wrong. So restore errno before returning from 
> handle_alias().

If we rely on the value of errno we should always immediately store it's value anyway. On some neolithic systems like the "MSVCRT.DLL" C runtime library on Windows (used by e.g. the Mingw compiler, don't know about Cygwin) a lot of runtime functions actually even reset the value of errno to 0 on success!

-- 
Marco Roeland
Previous: Andreas EricssonNext: Christopher Faylor
Message 8 of 9 in “git.c: Re-introduce sane error messages on missing commands.”
  1. git.c: Re-introduce sane error messages on missing commands.Andreas Ericsson, Jun 27, 2006
  2. Junio C HamanoJun 27, 2006
  3. Andreas EricssonJun 28, 2006
  4. Johannes SchindelinJun 28, 2006
  5. Junio C HamanoJun 28, 2006
  6. Johannes SchindelinJun 28, 2006
  7. Andreas EricssonJun 28, 2006
  8. Marco RoelandJun 28, 2006
  9. Christopher FaylorJun 28, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.