Re: [PATCH 0/2] tagsize < 8kb restriction

From: Björn Engelmann <bjengelmann@gmx.de>
Date: May 24, 2006, 19:16 UTC
Message-ID: <4474B10A.1020704@gmx.de>
In-Reply-To: <7vzmh81gfa.fsf@assigned-by-dhcp.cox.net>

Show 20 quoted lines

>> 2.) Searching for a way to add objects to the database I spent quite a
>> while to find the right command. Don't you think it would be much more
>> intuitive having an
>>
>>     git-create-object [-t <type>] [-n] [-f] [-z] [--stdin] <file> [-r
>> <ref-name>]
>>
>> command for creating any type of object (-t blob as default).
>>     
>
> No, I do not think we would want to make it too easy and relaxed
> to create arbitrary object-looking thing.  Each type have
> defined format and semantics, and creation of an object of each
> type should be validated.  I do not want to encourage bypassing
> it by introducing such a backdoor.  The backdoor is easy to
> write, but I suspect it would actively harm us, instead of
> helping us, by encouraging "let's build a custom type of object,
> we do not care if other people would not understand it"
> mentality.
>

Well, this is exactly what you have now in
    git-hash-object -w -t foo

That is why I said, all input should be validated by default. All I proposed was a) unify the tools in order to have less duplicate code (git-mktag, git-mktree & git-hash-object do merely the same except for the validating part) b) remove the possibility to introduce unchecked objects of arbitrary type (or only allow it with the -f = "force, use with caution"-option)

maybe I should have written "blob, tag, tree or commit" instead of "arbitrary". I did not mean really arbitrary like it is implemented right now in git-hash-object.

Bj