[PATCH 0/2] tagsize < 8kb restriction
- From
- Björn Engelmann <bjengelmann@gmx.de>
- Date
- May 22, 2006, 14:48 UTC
- Message-ID
- <4471CF23.1070807@gmx.de>
Hi,
I am currently working on an interface for source code quality assurance tools to automatically scan newly commited code. Since it is the only way to add data (scan-results) to an already-existing commit, I decided to use tags for that.
Since the scan-results will most definitly exeed the 8kb-limit, I would like to remove this artificial restriction.
I know I could also
git-hash-object -t tag -w
but prefer using the "official" way.
In order not to write duplicate code I used parts of index_pipe() in sha1_file.c
What I found odd when writing the patch was that main() in mktag.c uses xread() to read from stdin (which respects EAGAIN and EINTR return values), but index_pipe() in sha1_file.c just uses read() for doing merely the same thing. For unifying both routines i found that xread() might be the better choice.
Removing the restriction was pretty straightforward but do you think this would break something in other places ?
[PATCH 1/2]
remove the < 8kb restrinction from git-mktag[PATCH 2/2]
add more informative error messages to git-mktagBj