Re: [PATCH] Add git-annotate, a tool for assigning blame.

From: Andreas Ericsson <ae@op5.se>
Date: Feb 28, 2006, 09:08 UTC
Message-ID: <440412F5.9050909@op5.se>
In-Reply-To: <20060228084737.GA13537@mythryan2.michonline.com>

Ryan Anderson wrote:

Show 29 quoted lines

> On Tue, Feb 28, 2006 at 09:27:36AM +0100, Fredrik Kuivinen wrote:
> 
>>On Mon, Feb 20, 2006 at 04:01:56PM -0800, Junio C Hamano wrote:
>>
>>>Fredrik Kuivinen <freku045@student.liu.se> writes:
>>>
>>>
>>>>I have also been working on a blame program.
>>
>>...
>>
>>
>>>BTW, these days I always compile things with 
>>>
>>>	-Wall -Wdeclaration-after-statement
>>>
>>>which caught quite a many.
>>
>>Just out of curiosity, why do you prefer declarations before
>>statements?
> 
> 
> I won't speak for Junio, but the explanations I've heard in the past are
> basically:
> 
> 1) It keeps all declarations in one spot.
> 2) If your function is complicated enough to not need a variable until
> fairly far into the function, it probably should be two (or more) functions.
>

3) Not all compilers support it.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231