Re: [PATCH] Add git-annotate, a tool for assigning blame.

From: Ryan Anderson <ryan@michonline.com>
Date: Feb 28, 2006, 08:47 UTC
Message-ID: <20060228084737.GA13537@mythryan2.michonline.com>
In-Reply-To: <20060228082736.GA4593@c165.ib.student.liu.se>

On Tue, Feb 28, 2006 at 09:27:36AM +0100, Fredrik Kuivinen wrote:

Show 15 quoted lines

> On Mon, Feb 20, 2006 at 04:01:56PM -0800, Junio C Hamano wrote:
> > Fredrik Kuivinen <freku045@student.liu.se> writes:
> > 
> > > I have also been working on a blame program.
> 
> ...
> 
> > BTW, these days I always compile things with 
> > 
> > 	-Wall -Wdeclaration-after-statement
> > 
> > which caught quite a many.
> 
> Just out of curiosity, why do you prefer declarations before
> statements?

I won't speak for Junio, but the explanations I've heard in the past are basically:

1) It keeps all declarations in one spot.
2) If your function is complicated enough to not need a variable until
fairly far into the function, it probably should be two (or more) functions.

Basically, I think that there's not wrong with doing it that way, per se, just that it's sometimes a symptom of other problems, so fi you look for the symptom, the problem sometimes is more obvious.

-- 
Ryan Anderson
  sometimes Pug Majere