Re: [PATCH] doc: clarify how -S works
- From
John Tapsell <johnflux@gmail.com>
- Date
- Mar 3, 2009, 17:39 UTC
- Message-ID
- <43d8ce650903030939u73f09171uf4041b6d9824b698@mail.gmail.com>
- In-Reply-To
- <20090303171138.GA454@coredump.intra.peff.net>
2009/3/3 Jeff King <peff@peff.net>:
Show 21 quoted lines
> On Tue, Mar 03, 2009 at 08:42:12AM -0800, Junio C Hamano wrote: > >> In retrospect, because --pickaxe was designed primarily for Porcelain use, >> it was a mistake for it to have taken a short-and-sweet -S synonym. > > Hmm. I actually like the pickaxe behavior and find it useful for > searching. IOW, I consider it a porcelain feature, just perhaps not the > one that some people are expecting. > >> > -S<string>:: >> > - Look for differences that contain the change in <string>. >> > + Look for differences that introduce or remove an instance of >> > + <string>. Note that this is different than the string simply >> > + appearing in diff output; see the 'pickaxe' entry in >> > + linkgit:gitdiffcore[7] for more details. >> >> Look for differences that change the number of occurrences of <string>? > > Yes, that is technically correct. I was trying to find a wording that > was a little less "this is literally what it does" and more "this is > what you might find it useful for".
Is there any way to have an option to also match any line containing the string? That might be the best way to document it, as well as being very useful:
-s<string> Look for any additions, removals or changes in any line containing <string> -S<string> Look only for any additions or removals of the <string> in any line
John