Re: git log -Sfoo ignores indentation (whitespace?) changes...

From: Jeff King <peff@peff.net>
Date: Mar 3, 2009, 16:25 UTC
Message-ID: <20090303162519.GE32079@coredump.intra.peff.net>
In-Reply-To: <49AD547E.7030703@drmicha.warpmail.net>

On Tue, Mar 03, 2009 at 05:02:06PM +0100, Michael J Gruber wrote:

Show 6 quoted lines

> > but what it actually does is find changes where the string was introduced
> > or removed. So it literally counts the number of occurences before and
> > after the commit, and the commit is interesting if they are not equal.
> 
> Hmm. The diffcore doc sounds more like if the filepair is picked if
> #before > 0 and #after = 0, but not if #after > 0.

Nope, the code is #before != #after. There are some special cases around deleted and unmerged files, but the obvious one is:

    $ sed -n 89,92p diffcore-pickaxe.c
                    else if (!diff_unmodified_pair(p) &&
                             contains(p->one, needle, len, regexp) !=
                             contains(p->two, needle, len, regexp))
                            has_changes++;

So maybe the diffcore documentation needs to be clarified.

> In any case, the pickaxe can't detect moving around of strings, right?

No, it won't (and see my other mail elsewhere in the thread for why that is actually hard to define).

-Peff