Re: [PATCH] scalar: fix wrong shell hashbang

From: Victoria Dye <vdye@github.com>
Date: Sep 18, 2022, 20:08 UTC
Message-ID: <433bf552-db20-9989-92c5-ee625ce9337a@github.com>
In-Reply-To: <pull.1355.git.1663420281187.gitgitgadget@gmail.com>

ZheNing Hu via GitGitGadget wrote:

Show 24 quoted lines

> From: ZheNing Hu <adlternative@gmail.com>
> 
> $SHELL_PATH_SQ haven't been set in scalar's Makefile,
> bin-wrappers/scalar will begin with wrong hashbang "#!",
> fix it by setting $SHELL_PATH and $SHELL_PATH_SQ in
> scalar's Makefile.
> 
> Signed-off-by: ZheNing Hu <adlternative@gmail.com>
> ---
>     scalar: fix wrong shell hashbang
>     
>     The bin-wrappers/scalar seems like missing setting $SHELL_PATH_SQ which
>     lead to I can't execute bin-wrappers/scalar correctly, which output
>     error:
>     
>     zsh: exec format error: scalar
>     
>     (this bug will not turn out in bash)
>     
>     The bin-wrappers/scalar begin with wrong hashbang "#!", which cannot
>     figure out by zsh. So this patch want to fix this problem.
>     
>     v1: Setting $SHELL_PATH and $SHELL_PATH_SQ in scalar/Makefile.
>

Thanks for finding this! However, while your patch fixes the error you've identified (I was able to recreate both the original issue and apply your patch to fix it), I believe it has already been fixed in 'next' by 7b5c93c6c6 (scalar: include in standard Git build & installation, 2022-09-02) (archive: [1]).

[1] https://lore.kernel.org/git/bc2092a7a7aae640b547bde8db0c0a26ce31278a.1662134210.git.gitgitgadget@gmail.com/