Re: cg-log patches

From: Sean <seanlkml@sympatico.ca>
Date: May 9, 2005, 03:45 UTC
Message-ID: <4302.10.10.10.24.1115610350.squirrel@linux1>
In-Reply-To: <20050508234936.GA26624@diku.dk>

On Sun, May 8, 2005 7:49 pm, Jonas Fonseca said:

Hey Jonas,

>>     Fix cg-log -f option so that a complete list of files is
>>     displayed when a commit has more than one parent.
>
> This sounds great.

You might want to rip it out and submit it, because it's not likely to see the light of day otherwise.

> The reason I put it at the top was to make it more similar to GNU-style
> changelogs (if there is such a style).

Yeah, I felt a bit guilty sliding that shift in, really I had no rationale other than it looked better _to me_.

Show 5 quoted lines

> I think that will make `-f' less usable because of the extra scrolling.
>
> Assuming use of wc will not create more dependency nightmares and the
> extra overhead is acceptable here is a patch that will wrap file listing
> lines near the 80th column.

Your patch will work fine but I did test my version out against the kernel repo and it didn't seem to be a problem.

Cheers, Sean