Re: [PATCH 2/2 v2] run-command (Windows): Run dashless "git <cmd>" (solves part of problem with system_path)
- From
Steffen Prohaska <prohaska@zib.de>
- Date
- Jul 29, 2008, 05:55 UTC
- Message-ID
- <42EF8777-BABC-4757-AD49-627320F24D39@zib.de>
- In-Reply-To
- <7v4p69meka.fsf@gitster.siamese.dyndns.org>
On Jul 29, 2008, at 7:42 AM, Junio C Hamano wrote:
Show 29 quoted lines
> "Shawn O. Pearce" <spearce@spearce.org> writes: > >> This feels wrong to me. fast-import probably won't be adversly >> impacted by not being able to read /etc/gitconfig, unless the user >> has set something like core.deltaBaseCacheLimit and is doing an >> incremental import. But other non-builtins may be impacted. >> >> It feels like we're fixing this in the wrong place. If the issue >> is we don't find our installation directory correctly, we should >> find our installation directory correctly, not work around it by >> calling builtins through the git wrapper. >> >> Though I can see where it may be a good idea to at some point >> in the future (git 1.7?) stop creating the redundant builtin >> links under libexec/git-core. > > I agree; that is why I already applied Steffen's original patch with > quite > a different justification from the updated one: > > commit b048b9a803f48d88595877271b53bf9ec400e4ba > Author: Steffen Prohaska <prohaska@zib.de> > Date: Mon Jul 28 07:50:28 2008 +0200 > > run-command (Windows): Run dashless "git <cmd>" > > We prefer running the dashless form, and POSIX side already does > so; we > should use it in MinGW's start_command(), too.
Thanks for reading my mind ;-) This was the alternative justification I had in mind after reading my patch again.
Steffen