Re: [PATCH 2/2 v2] run-command (Windows): Run dashless "git <cmd>" (solves part of problem with system_path)
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Jul 29, 2008, 05:24 UTC
- Message-ID
- <20080729052459.GC11947@spearce.org>
- In-Reply-To
- <1217308647-23673-1-git-send-email-prohaska@zib.de>
Steffen Prohaska <prohaska@zib.de> wrote:
> We prefer running the dashless form, so we should use it in MinGW's > start_command(), too.
...
> - We have non-builtins that are implemented in C, e.g. fast-import.c. > These non-builtins will still compute wrong paths.
This feels wrong to me. fast-import probably won't be adversly impacted by not being able to read /etc/gitconfig, unless the user has set something like core.deltaBaseCacheLimit and is doing an incremental import. But other non-builtins may be impacted.
It feels like we're fixing this in the wrong place. If the issue is we don't find our installation directory correctly, we should find our installation directory correctly, not work around it by calling builtins through the git wrapper.
Though I can see where it may be a good idea to at some point in the future (git 1.7?) stop creating the redundant builtin links under libexec/git-core.
-- Shawn.