Re: GSoC draft proposal: Line-level history browser

From: Bo Yang <struggleyb.nku@gmail.com>
Date: Mar 23, 2010, 12:23 UTC
Message-ID: <41f08ee11003230523h2c5f93b1l7e94d6c85a93a706@mail.gmail.com>
In-Reply-To: <201003231222.40745.jnareb@gmail.com>

Hi,

On Tue, Mar 23, 2010 at 7:22 PM, Jakub Narebski <jnareb@gmail.com> wrote:

Show 28 quoted lines

>
> This would work with the simplest case, but not in more complicated
> cases, like for example preimage and postimage with different size.
>
> Take for example the following chunk (fragment):
>
> diff --git a/run-command.c b/run-command.c
> index 2feb493..3206d61 100644
> --- a/run-command.c
> +++ b/run-command.c
> @@ -67,19 +67,21 @@ static int child_notifier = -1;
>
>  static void notify_parent(void)
>  {
> -       write(child_notifier, "", 1);
> +       ssize_t unused;
> +       unused = write(child_notifier, "", 1);
>  }
>
>  static NORETURN void die_child(const char *err, va_list params)
>
> If you follow ssize_t line, it is created.  If you follow line with
> write, which is 2nd line in postimage, its previous version is 1st
> line in preimage.
>
>
> Another example would be reordering of lines, or reordering with
> some change.

Ah, yes, you are right.

And now, I really get the difference between the understanding about line level browser of us. :) When users want to browsing the history of some line or line range, you want to display only the related lines to them, but I want to display the minim diff hunk to them. :) And I think displaying the minimum diff hunk is sensible and feasible. Could you please tell me how do you think about this?

Regards! Bo