git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] doc: fix typos via codespell

From
KHKristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date
Jun 1, 2026, 20:59 UTC
Message-ID
<415f5646-4f4e-48be-a252-8db883f431d9@app.fastmail.com>
In-Reply-To
<xmqqo6hv9i1w.fsf@gitster.g>
On Mon, Jun 1, 2026, at 03:16, Junio C Hamano wrote:
Show 23 quoted lines
>[snip]
>
> However, there are things that BREAK tests.
>
>> diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh
>> index ac4a5b2734..869fb4a14e 100755
>> --- a/t/t1700-split-index.sh
>> +++ b/t/t1700-split-index.sh
>> @@ -502,7 +502,7 @@ test_expect_success 'do not refresh null base index' '
>>  		git checkout main &&
>>  		git update-index --split-index &&
>>  		test_commit more &&
>> -		# must not write a new shareindex, or we wont catch the problem
>> +		# must not write a new shareindex, or we won't catch the problem
>>  		git -c splitIndex.maxPercentChange=100 merge --no-edit side-branch 2>err &&
>>  		# i.e. do not expect warnings like
>>  		# could not freshen shared index .../shareindex.00000...
>
> The edit above is made to a STRING that is enclosed inside a pair of
> single quote.  If we want to use "won't", we would need to write "We
> won'\''t", but while it may be syntactically correct as a part of
> shell script, it is a pointless change, as the target audience wants
> to see this line as if it is just a plain text.

Sorry about not testing this on v1. “Surely this does not affect the code...” strikes again.

Show 5 quoted lines
>
> "We will not" would be acceptable,
>
>> diff --git a/t/t3909-stash-pathspec-file.sh b/t/t3909-stash-pathspec-file.sh
>>[snip]
Previous: Junio C HamanoNext: Andrew Kreimer
Message 13 of 17 in “doc: fix typos via codespell”
  1. doc: fix typos via codespellAndrew Kreimer, May 6, 2026
  2. Kristoffer HaugsbakkMay 9, 2026
  3. Kristoffer HaugsbakkMay 28, 2026
  4. Junio C HamanoMay 28, 2026
  5. Junio C HamanoMay 10, 2026
  6. Weijie YuanMay 23, 2026
  7. docs: fix typos and grammarWeijie Yuan, May 29, 2026
  8. Junio C HamanoJun 1, 2026
  9. Weijie YuanJun 2, 2026
  10. Weijie YuanJun 2, 2026
  11. doc: fix typos via codespellAndrew Kreimer, May 31, 2026
  12. Junio C HamanoJun 1, 2026
  13. Kristoffer HaugsbakkJun 1, 2026
  14. doc: fix typos via codespellAndrew Kreimer, Jun 2, 2026
  15. Junio C HamanoJun 2, 2026
  16. Johannes SchindelinJun 6, 2026
  17. Junio C HamanoJun 8, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.