git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

From
TTwiinz <twiinz@gmail.com>
Date
May 19, 2008, 05:34 UTC
Message-ID
<412a1d9a0805182234i18e2da4ckf428b2c134e174d1@mail.gmail.com>
In-Reply-To
<20080519040746.GA29038@spearce.org>
Hi Shawn,

No worries for Signed-off-by and "Twiinz <twiinz@gmail.com>" for the attribution.

Sorry for the lack of information in the patch, I'm rather new to that, I'll check out how to make it better for future contributions.

Cheers, /twiinz

On Mon, May 19, 2008 at 11:07 AM, Shawn O. Pearce <spearce@spearce.org> wrote:
Show 18 quoted lines
> Twiinz <twiinz@gmail.com> wrote:
>> In git-gui after clicking either on 'Create New Repository' or 'Open
>> Existing Repository' the form elements aren't centered like they are
>> pretty much everywhere else in the app. At least when ran on a mac,
>> haven't checked on other platforms.
>>
>> Using grid instead of pack seems to fix this.
>
> Thanks.  This is a reasonable solution.  Signed-off-by tag?  Do you
> want the attribution to be just "Twiinz <twiinz@gmail.com>"?
>
> I ask because the patch is a valid patch and it does apply, but it
> isn't a standard git patch and wasn't sent inline, so git-am wasn't
> able to extract and apply everything for me automagically.
>
> --
> Shawn.
>
Previous: Shawn O. PearceNext: Johannes Schindelin
Message 3 of 12 in “Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons”
  1. TwiinzMay 18, 2008
  2. Shawn O. PearceMay 19, 2008
  3. TwiinzMay 19, 2008
  4. Johannes SchindelinMay 19, 2008
  5. Junio C HamanoMay 21, 2008
  6. Shawn O. PearceMay 22, 2008
  7. TwiinzMay 22, 2008
  8. Shawn O. PearceMay 22, 2008
  9. TwiinzMay 22, 2008
  10. Junio C HamanoMay 22, 2008
  11. Shawn O. PearceMay 22, 2008
  12. Junio C HamanoMay 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.