git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons

From
Shawn O. Pearce <spearce@spearce.org>
Date
May 22, 2008, 12:55 UTC
Message-ID
<20080522125559.GO29038@spearce.org>
In-Reply-To
<412a1d9a0805220545veb9af51y833aed2234d258b@mail.gmail.com>
Twiinz <twiinz@gmail.com> wrote:
Show 17 quoted lines
> On Thu, May 22, 2008 at 7:11 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
> > In this case it is a very trivial patch.  Anyone who tries to do
> > the same thing is likely to come up with the same result, or one
> > that is close enough that it looks identical anyway.
> >
> > Still, it isn't in my main tree, because it is lacking a proper
> > Signed-off-by tag by the original author.
> 
> Sorry for the late response,
> 
> It's a very trivial patch, indeed.
> 
> I'm still a bit confused with those Signed-off-by things. Anyway I
> sign hereby that:
> - I coded those few lines myself
> - I didn't steal them from anyone
> - I'm not going to sue anybody over its utilization
See "Sign your work" of git.git/Documentation/SubmittingPatches:
  http://repo.or.cz/w/git.git?a=blob;f=Documentation/SubmittingPatches;h=0e155c936c25255706bc6d47651c2b336c628417;hb=377d9c409ffe0f0d994b929aeb94716139207b9d
I think most reasonable people would say your statement has roughly
the same intent and effect as the Developer's Certificate of
Origin 1.1.
 
> If there's more that need to be done to get this patch approved please
> point me to some online materials that detail the process.
> 
> I hope that helps,
I'm going to edit your commit and add the signed off by line for you:
	Signed-off-by: Twiinz <twiinz@gmail.com>
Thanks.
-- 
Shawn.
Previous: TwiinzNext: Twiinz
Message 8 of 12 in “Two minor tweaks on git-gui where textboxes weren't vertically centered with their labels and buttons”
  1. TwiinzMay 18, 2008
  2. Shawn O. PearceMay 19, 2008
  3. TwiinzMay 19, 2008
  4. Johannes SchindelinMay 19, 2008
  5. Junio C HamanoMay 21, 2008
  6. Shawn O. PearceMay 22, 2008
  7. TwiinzMay 22, 2008
  8. Shawn O. PearceMay 22, 2008
  9. TwiinzMay 22, 2008
  10. Junio C HamanoMay 22, 2008
  11. Shawn O. PearceMay 22, 2008
  12. Junio C HamanoMay 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.