Re: [PATCH v2 0/4] Fix Sparse Warning

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Apr 24, 2020, 16:40 UTC
Message-ID: <411ec3ea-162e-8e52-0133-3108e0c38f0d@ramsayjones.plus.com>
In-Reply-To: <cover.1587740959.git.congdanhqx@gmail.com>

On 24/04/2020 16:12, Đoàn Trần Công Danh wrote:

> Change in v2 from v1:
> * = { 0 } is an idiom to zero the structure, it shouldn't be changed
> * change in [4/4] for prototype
> * ignore diffent function prototype

Apart from the regex patch [2/4], these all look good to me.

Thanks!

ATB, Ramsay Jones

Show 15 quoted lines

> 
> Đoàn Trần Công Danh (4):
>   test-parse-pathspec-file.c: s/0/NULL/ for pointer type
>   compat/regex: include alloca.h before undef it
>   graph.c: limit linkage of internal variable
>   progress.c: silence cgcc suggestion about internal linkage
> 
>  compat/regex/regex.c                | 1 +
>  graph.c                             | 2 +-
>  progress.c                          | 2 +-
>  progress.h                          | 8 ++++++++
>  t/helper/test-parse-pathspec-file.c | 6 +++---
>  t/helper/test-progress.c            | 9 +--------
>  6 files changed, 15 insertions(+), 13 deletions(-)
>