Re: [PATCH v2 2/4] compat/regex: include alloca.h before undef it

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Apr 24, 2020, 18:29 UTC
Message-ID: <0bee8daa-99d0-4939-e225-8783bc0457f8@ramsayjones.plus.com>
In-Reply-To: <20200424170916.GA29153@danh.dev>

On 24/04/2020 18:09, Danh Doan wrote:

> On 2020-04-24 17:56:46+0100, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

[snip]

Show 10 quoted lines

>> So, again I don't see a problem. I guess it is possible that the
>> version of sparse I am using (see above) has _also_ fixed this
>> problem, in addition to the prototype attribute placement fix.
>>
>> Another option is that the version of glibc also matters. (I am
>> on Linux Mint, which is based on Ubuntu 18.04 LTS) It would not
>> be the first time that I have seen errors in system header files
>> change from one release to the next ...
> 
> I'm using a Linux distro with musl libc.

Ah, OK.

I just tried re-building v0.6.1 to see if any '<alloca.h>' related errors/warnings show up for me, but they don't:

  $ sparse --version
  v0.6.1
  $ 
  $ git checkout master
  Switched to branch 'master'
  Your branch is up-to-date with 'origin/master'.
  $ 
  $ make clean
  GIT_VERSION = 2.26.2.266.ge870325ee8
  ...
  $ 
  $ make NO_REGEX=1 compat/regex/regex.sp
      SP compat/regex/regex.c
  compat/regex/regex_internal.c:925:1: error: symbol 're_string_context_at' redeclared with different type (originally declared at compat/regex/regex_internal.h:433) - different modifiers
  $

> I guess it's the main culprit?

Quite possible, I guess. What do the errors/warnings look like?

Show 5 quoted lines

> I have another box with glibc, but it's mostly in Windows 10,
> because my sister is its main user.
> 
> I'll take a look if it make that warning when my sister agree to leave
> that box to me.

Sounds good.

ATB, Ramsay Jones