Re: [PATCH 3/3] Add support for GIT_ONE_FILESYSTEM
- From
Erik Faye-Lund <kusmabite@googlemail.com>
- Date
- Mar 31, 2010, 00:54 UTC
- Message-ID
- <40aa078e1003301754u3a1e5e9je7bb2aa2dc04f6a1@mail.gmail.com>
- In-Reply-To
- <alpine.LFD.2.00.1003301610151.3707@i5.linux-foundation.org>
On Wed, Mar 31, 2010 at 1:12 AM, Linus Torvalds <torvalds@linux-foundation.org> wrote:
Show 16 quoted lines
> > > On Tue, 30 Mar 2010, Jeff King wrote: >> >> Fashionably late, of course. I agree with your reasoning that it is >> a more sane default. The only thing that would make me hesitate on it >> now is that it is a behavior change. I suspect the group we would be >> breaking is small or even zero, though. > > Well, I have to admit that I'm a _tiny_ bit nervous that some odd OS or > filesystem has special magic st_dev rules so that it changes randomly even > within a filesystem, but that would be very non-posix (think of the > confusion it would cause standard UNIX tools like 'find -xdev' etc), so > it's more a worry of "I have no idea what st_dev means on Windows" than > anything really solid. >
st_dev means "Drive number of the disk containing the file (same as st_rdev)."[1], and mounting file systems as subdirs of other file systems is rare (but possible) on Windows.
However, in our (f)stat implementation, st_dev means 0 -- but this might be possible to improve on.
[1]: http://msdn.microsoft.com/en-us/library/14h5k7ff(VS.71).aspx
-- Erik "kusma" Faye-Lund