git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] truncate cwd string before printing error message

From
Lars R. Damerow <lars@pixar.com>
Date
Mar 17, 2010, 19:55 UTC
Message-ID
<1268855753-25840-3-git-send-email-lars@pixar.com>
In-Reply-To
<1268855753-25840-1-git-send-email-lars@pixar.com>

Without this truncation the error message printed only shows the cwd from the start of the search, not where it failed.

Signed-off-by: Lars R. Damerow <lars@pixar.com>
---
 setup.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/setup.c b/setup.c
index 5716d90..f0b56b9 100644
--- a/setup.c
+++ b/setup.c
@@ -422,8 +422,10 @@ const char *setup_git_directory_gently(int *nongit_ok)
 			}
 			die("Not a git repository (or any of the parent directories): %s", DEFAULT_GIT_DIR_ENVIRONMENT);
 		}
-		if (chdir(".."))
+		if (chdir("..")) {
+			cwd[offset] = '\0';
 			die_errno("Cannot change to '%s/..'", cwd);
+		}
 	}
 
 	inside_git_dir = 0;
-- 
1.6.5.2
Previous: Lars R. DamerowNext: Lars R. Damerow
Message 3 of 20 in “Add support for GIT_ONE_FILESYSTEM”
  1. 0/3 Add support for GIT_ONE_FILESYSTEMLars R. Damerow, Mar 17, 2010
  2. 1/3 config.c: remove static keyword from git_env_bool()Lars R. Damerow, Mar 17, 2010
  3. 2/3 truncate cwd string before printing error messageLars R. Damerow, Mar 17, 2010
  4. 3/3 Add support for GIT_ONE_FILESYSTEMLars R. Damerow, Mar 17, 2010
  5. Jeff KingMar 28, 2010
  6. Jeff KingMar 28, 2010
  7. Junio C HamanoMar 28, 2010
  8. Lars DamerowMar 28, 2010
  9. Jeff KingMar 30, 2010
  10. Linus TorvaldsMar 30, 2010
  11. Thomas RastMar 30, 2010
  12. Jeff KingMar 30, 2010
  13. Jeff KingMar 30, 2010
  14. Junio C HamanoMar 30, 2010
  15. Linus TorvaldsMar 30, 2010
  16. Erik Faye-LundMar 31, 2010
  17. GIT_ONE_FILESYSTEM: flip the default to stop at filesystem boundariesJunio C Hamano, Apr 4, 2010
  18. Rename ONE_FILESYSTEM to DISCOVERY_ACROSS_FILESYSTEMJunio C Hamano, Apr 4, 2010
  19. Matthieu MoyApr 4, 2010
  20. Junio C HamanoApr 4, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.