Re: [PATCH v2 05/14] mingw: support waitpid with pid > 0 and WNOHANG
On Fri, Jan 15, 2010 at 11:28 PM, Johannes Sixt <j6t@kdbg.org> wrote:
Show 18 quoted lines
> On Freitag, 15. Januar 2010, Erik Faye-Lund wrote:
>> static inline int waitpid(pid_t pid, int *status, unsigned options)
>> {
>> + if (pid > 0 && options & WNOHANG) {
>> + if (WAIT_OBJECT_0 != WaitForSingleObject((HANDLE)pid, 0))
>> + return 0;
>> + options &= ~WNOHANG;
>> + }
>> +
>> if (options == 0)
>> return _cwait(status, pid, 0);
>> errno = EINVAL;
>
> With this change, and in particular the one in the next patch, this function
> grows too large to be 'static inline'.
>
> -- Hannes
>--
Erik "kusma" Faye-Lund
Erik Faye-Lund <kusmabite@googlemail.com>