[PATCH v2 10/14] daemon: use full buffered mode for stderr
- From
Erik Faye-Lund <kusmabite@googlemail.com>
- Date
- Jan 15, 2010, 21:30 UTC
- Message-ID
- <1263591033-4992-11-git-send-email-kusmabite@gmail.com>
- In-Reply-To
- <1263591033-4992-1-git-send-email-kusmabite@gmail.com>
Windows doesn't support line buffered mode for file streams, so let's just use full buffered mode with a big buffer ("4096 should be enough for everyone") and add explicit flushing.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com> --- daemon.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/daemon.c b/daemon.c index 2d63cbc..fc2c150 100644 --- a/daemon.c +++ b/daemon.c @@ -66,12 +66,14 @@ static void logreport(int priority, const char *err, va_list params) syslog(priority, "%s", buf); } else { /* - * Since stderr is set to linebuffered mode, the + * Since stderr is set to buffered mode, the * logging of different processes will not overlap + * unless they overflow the (rather big) buffers. */ fprintf(stderr, "[%"PRIuMAX"] ", (uintmax_t)getpid()); vfprintf(stderr, err, params); fputc('\n', stderr); + fflush(stderr); } } @@ -1062,7 +1064,7 @@ int main(int argc, char **argv) set_die_routine(daemon_die); } else /* avoid splitting a message in the middle */ - setvbuf(stderr, NULL, _IOLBF, 0); + setvbuf(stderr, NULL, _IOFBF, 4096); if (inetd_mode && (group_name || user_name)) die("--user and --group are incompatible with --inetd");
-- 1.6.6.211.g26720