Re: Segfault in "git remote show <remote-name>"

From: Erik Faye-Lund <kusmabite@googlemail.com>
Date: May 26, 2009, 18:54 UTC
Message-ID: <40aa078e0905261154o7f8901e4k8526c787e0e9d3ac@mail.gmail.com>
In-Reply-To: <20090525190121.GA3979@localhost>

On Mon, May 25, 2009 at 9:01 PM, Clemens Buchacher <drizzd@aon.at> wrote:

Show 7 quoted lines

> Subject: [PATCH] fix segfault showing an empty remote
>
> In case of an empty list, the search for its tail caused a
> NULL-pointer dereference.
>
> Reported-by: Erik Faye-Lund <kusmabite@googlemail.com>
> Signed-off-by: Clemens Buchacher <drizzd@aon.at>

Tested-by: Erik Faye-Lund <kusmabite@googlemail.com>

Show 10 quoted lines

> ---
>
> On Mon, May 25, 2009 at 06:10:12PM +0200, Erik Faye-Lund wrote:
>> I've been messing around a bit, trying to set up a gitosis repo to
>> mirror one of my projects. Now, I added the remote to my project, but
>> when running "git remote show <remote-name>", I'm getting a segfault
>> in builtin-remote.c at line 303 ("while (ref->next)"), because ref
>> itself is NULL.
>
> This should fix it.

Thanks a lot for looking into and fixing this. I have verified that the patch indeed fixes the issue for me.

-- 
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656