git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] match_refs: search ref list tail internally

From
Clemens Buchacher <drizzd@aon.at>
Date
May 28, 2009, 09:26 UTC
Message-ID
<20090528092624.GA8787@localhost>
In-Reply-To
<7vtz35hfk7.fsf@alter.siamese.dyndns.org>
On Thu, May 28, 2009 at 12:06:32AM -0700, Junio C Hamano wrote:
Show 12 quoted lines
> It so happens that http-push.c never looked at remote_tail to do further
> processing on the list after match_refs() returned, and that is why your
> patch does not break http-push.c.
> 
> Any third-party patch to http-push.c
> that relied on the old guarantee will textually merge cleanly but will
> subtly break with this change.
> 
> Other parts of this patch removes the local "remote_tail" variables, and
> it is very clear that they do not have this problem; any third-parth patch
> will break if they used remote_tail after match_refs() returned, so this
> change is a safe one for them.

Yes, I tried to get rid of remote_tail entirely, but I could not come up with a solution immediately. We could insert to the front of the list instead. I'll try that.

> I wonder what interaction this change will have with the http-push
> clean-up Ray Chuan has been working on...
For me, t5540 currently segfaults on pu. I'm looking into it.
Previous: Junio C HamanoNext: Clemens Buchacher
Message 7 of 9 in “Segfault in "git remote show <remote-name>"”
  1. Erik Faye-LundMay 25, 2009
  2. Clemens BuchacherMay 25, 2009
  3. Jay SoffianMay 26, 2009
  4. 1/2 fix segfault showing an empty remoteClemens Buchacher, May 27, 2009
  5. 2/2 match_refs: search ref list tail internallyClemens Buchacher, May 27, 2009
  6. Junio C HamanoMay 28, 2009
  7. Clemens BuchacherMay 28, 2009
  8. match_refs: search ref list tail internallyClemens Buchacher, May 31, 2009
  9. Erik Faye-LundMay 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.