git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin-fast-export.c: add default case to avoid crash on corrupt repo

From
Erik Faye-Lund <kusmabite@googlemail.com>
Date
Mar 22, 2009, 12:32 UTC
Message-ID
<40aa078e0903220532n41895acemff175e4012e28ea6@mail.gmail.com>
In-Reply-To
<40aa078e0903220522g66cf2172l9f1a43ed562cc4d3@mail.gmail.com>
> tag-object is NULL. Now, I'm no expert, but from browsing some code,
> it seems that "parse_object(tag->object.sha1)" should have been
> performed on the tag before looking up the tagged object. Does this
> make sense?

I guess I forgot to mention that adding a call to parse_object() does make fast-exporting nested tags appear to work.

-- 
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656
Previous: Erik Faye-LundNext: Junio C Hamano
Message 4 of 6 in “builtin-fast-export.c: add default case to avoid crash on corrupt repo”
  1. builtin-fast-export.c: add default case to avoid crash on corrupt repoErik Faye-Lund, Mar 21, 2009
  2. Junio C HamanoMar 21, 2009
  3. Erik Faye-LundMar 22, 2009
  4. Erik Faye-LundMar 22, 2009
  5. Junio C HamanoMar 22, 2009
  6. Shawn O. PearceMar 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.