[PATCH] builtin-fast-export.c: add default case to avoid crash on corrupt repo
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Mar 21, 2009, 22:37 UTC
- Message-ID
- <1237675051-6688-1-git-send-email-kusmabite@gmail.com>
This small issue was discovered by Benjamin Kramers Clang-runs on the git code-base. If a tag object points to an object that is not a commit or a blob, an invalid pointer is dereferenced in the code that followed.
This patch fixes this issue, by giving an error instead. This should also be more useful when debugging corrupted repos.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com> --- builtin-fast-export.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/builtin-fast-export.c b/builtin-fast-export.c index fdf4ae9..26b2a93 100644 --- a/builtin-fast-export.c +++ b/builtin-fast-export.c @@ -375,6 +375,9 @@ static void get_tags_and_duplicates(struct object_array *pending, case OBJ_BLOB: handle_object(tag->object.sha1); continue; + default: + die ("Unexpected object of type %s", + typename(tag->object.type)); } break; default:
-- 1.6.2.1.215.gf786.dirty