Re: [PATCH v3 4/6] rev-list: support delimiting objects with NUL bytes

From: Justin Tobler <jltobler@gmail.com>
Date: Mar 19, 2025, 16:02 UTC
Message-ID: <3kjvitvmmi776obptqex7eo32qawegh6lzkih37ppkuina5ohg@loulhg5beghp>
In-Reply-To: <CAP8UFD1JAkTESnEOP621uECvoFGFmQ8SRd372hPLDhNzALAN+A@mail.gmail.com>

On 25/03/19 01:35PM, Christian Couder wrote:

Show 14 quoted lines

> On Fri, Mar 14, 2025 at 1:01 AM Justin Tobler <jltobler@gmail.com> wrote:
> 
> > +test_expect_success 'rev-list -z' '
> > +       test_when_finished rm -rf repo &&
> > +
> > +       git init repo &&
> > +       test_commit -C repo 1 &&
> > +       test_commit -C repo 2 &&
> > +
> > +       oid1=$(git -C repo rev-parse HEAD) &&
> > +       oid2=$(git -C repo rev-parse HEAD~) &&
> 
> It seems to me that HEAD is at commit 2 and HEAD~ at commit 1 instead
> of the other way around.

In this case, oid1 and oid2 were ordered based on how they would show up in ouput, but this is somewhat confusing because its not the order they were committed in.

I'll change it to be in commit order instead.

Thanks, -Justin