git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: recent glob expansion breakage on Windows?

From
LELaszlo Ersek <lersek@redhat.com>
Date
Mar 9, 2018, 09:41 UTC
Message-ID
<3f8076fa-ead3-4034-2d41-364b72169873@redhat.com>
In-Reply-To
<20180308220356.GA171451@aiede.svl.corp.google.com>
On 03/08/18 23:03, Jonathan Nieder wrote:
Show 36 quoted lines
> +git-for-windows
> Hi,
> 
> Laszlo Ersek wrote:
> 
>> Jaben reports that git-send-email is suddenly failing to expand the
>> "*.patch" glob for him, at the Windows CMD prompt:
>>
>> ---------
>> E:\...>git send-email --suppress-cc=author --suppress-cc=self --suppress-cc=cc --suppress-cc=sob --dry-run *.patch
>>
>> No patch files specified!
>> ---------
>>
>> Whereas, moving the same patch files to another subdir, and then passing
>> the subdir to git-send-email, works fine.
>>
>> I seem to have found some $^O based perl code in the git tree that
>> expands the glob manually (in place of the shell) on Windows -- however,
>> that code looks ancient ^W very stable, and doesn't seem to explain the
>> sudden breakage.
>>
>> Is it possible that a separate perl update on Jaben's Windows box is
>> causing this? Or does the breakage look consistent with a recent git change?
>>
>> Has anyone else reported something similar recently?
> 
> This reminds me of https://github.com/git-for-windows/git/issues/339.
> There, Johannes Schindelin writes (about a different command):
> 
> | This is expected because neither PowerShell nor cmd.exe nor git.exe
> | expand wildcards. Those examples you found were written with a shell
> | in mind, and the shell expands wildcards (hence Git does not think
> | it needs to).
> 
> That may or may not also apply to send-email.

Thank you for the reference -- I can't say whether closing issue #339 as WONTFIX was justified or not, but it certainly seems inconsistent with Jaben's earlier experience (to my understanding), i.e. that git did expand the glob.

> In what version did it work?

Jaben, can you please answer that? (One version in which it is broken is 2.14.1.windows.1.) Can you perhaps ask your teammates about their git/windows versions (assuming the *.patch glob is expanded correctly for them)?

Thank you, Jonathan, Laszlo

Previous: Jonathan NiederNext: Carsey, Jaben
Message 3 of 4 in “recent glob expansion breakage on Windows?”
  1. Laszlo ErsekMar 8, 2018
  2. Jonathan NiederMar 8, 2018
  3. Laszlo ErsekMar 9, 2018
  4. Carsey, JabenMar 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.