Re: recent glob expansion breakage on Windows?

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mar 8, 2018, 22:03 UTC
Message-ID: <20180308220356.GA171451@aiede.svl.corp.google.com>
In-Reply-To: <e0ba9fb9-056e-4979-415b-f8eca47e2490@redhat.com>

+git-for-windows Hi,

Laszlo Ersek wrote:

Show 21 quoted lines

> Jaben reports that git-send-email is suddenly failing to expand the
> "*.patch" glob for him, at the Windows CMD prompt:
>
> ---------
> E:\...>git send-email --suppress-cc=author --suppress-cc=self --suppress-cc=cc --suppress-cc=sob --dry-run *.patch
>
> No patch files specified!
> ---------
>
> Whereas, moving the same patch files to another subdir, and then passing
> the subdir to git-send-email, works fine.
>
> I seem to have found some $^O based perl code in the git tree that
> expands the glob manually (in place of the shell) on Windows -- however,
> that code looks ancient ^W very stable, and doesn't seem to explain the
> sudden breakage.
>
> Is it possible that a separate perl update on Jaben's Windows box is
> causing this? Or does the breakage look consistent with a recent git change?
>
> Has anyone else reported something similar recently?

This reminds me of https://github.com/git-for-windows/git/issues/339. There, Johannes Schindelin writes (about a different command):

| This is expected because neither PowerShell nor cmd.exe nor git.exe
| expand wildcards. Those examples you found were written with a shell
| in mind, and the shell expands wildcards (hence Git does not think
| it needs to).

That may or may not also apply to send-email. In what version did it work?

Thanks, Jonathan

> Thanks (and sorry about the noise; this list might not be the best place
> to ask)!
> Laszlo