Re: [PATCH v3 3/5] pack-objects: fix handling of multiple --filter options

From: René Scharfe <l.s.r@web.de>
Date: Nov 30, 2022, 07:11 UTC
Message-ID: <3eefcd8c-3011-0317-c6d2-d554e03d8e6c@web.de>
In-Reply-To: <xmqq7czd2qq6.fsf@gitster.g>

Am 30.11.22 um 02:09 schrieb Junio C Hamano:

Show 11 quoted lines

> René Scharfe <l.s.r@web.de> writes:
>
>> Since 5cb28270a1 (pack-objects: lazily set up "struct rev_info", don't
>> leak, 2022-03-28) --filter options given to git pack-objects overrule
>> earlier ones, letting only the leftmost win and leaking the memory
>> allocated for earlier ones.  Fix that by only initializing the rev_info
>> struct once.
>
> I think "leftmost" -> "rightmost", if your command line goes from
> left to right?  Or "leftmost" -> "last" (e.g. "last one wins" over
> "earlier ones")?

Yes, indeed, I mixed up left and right again.

René

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.