From: René Scharfe <l.s.r@web.de>
Date: Wed, 30 Nov 2022 07:11:46 GMT
Subject: Re: [PATCH v3 3/5] pack-objects: fix handling of multiple --filter options
Message-ID: <3eefcd8c-3011-0317-c6d2-d554e03d8e6c@web.de>
In-Reply-To: <xmqq7czd2qq6.fsf@gitster.g>

Am 30.11.22 um 02:09 schrieb Junio C Hamano:
> René Scharfe <l.s.r@web.de> writes:
>
>> Since 5cb28270a1 (pack-objects: lazily set up "struct rev_info", don't
>> leak, 2022-03-28) --filter options given to git pack-objects overrule
>> earlier ones, letting only the leftmost win and leaking the memory
>> allocated for earlier ones.  Fix that by only initializing the rev_info
>> struct once.
>
> I think "leftmost" -> "rightmost", if your command line goes from
> left to right?  Or "leftmost" -> "last" (e.g. "last one wins" over
> "earlier ones")?

Yes, indeed, I mixed up left and right again.

René