git/list[1] front-page[2] threads[3] people[4] search[5] about
 

t9000-addresses.sh: unexpected pases

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Oct 21, 2016, 00:24 UTC
Message-ID
<3e9bfa01-d69c-05c1-e24e-960a3add2551@ramsayjones.plus.com>
Hi Matthieu,

I have started seeing unexpected passes in this test (am I the only one?) on the next and pu branch, which seems to be caused by commit e3fdbcc8 ("parse_mailboxes: accept extra text after <...> address", 13-10-2016). Thus:

  $ tail -15 ntest-out
  [15:17:44]
  All tests successful.
  Test Summary Report
  -------------------
  t9000-addresses.sh                               (Wstat: 0 Tests: 37 Failed: 0)
    TODO passed:   28, 30-31
  Files=760, Tests=13940, 484 wallclock secs ( 4.04 usr  1.30 sys + 60.52 cusr 36.76 csys = 102.62 CPU)
  Result: PASS
  make clean-except-prove-cache
  make[2]: Entering directory '/home/ramsay/git/t'
  rm -f -r 'trash directory'.* 'test-results'
  rm -f -r valgrind/bin
  make[2]: Leaving directory '/home/ramsay/git/t'
  make[1]: Leaving directory '/home/ramsay/git/t'
  $ 

I have not even looked, but I suspect that it simply requires a change from expect_fail to expect_success, since your commit has 'fixed' these tests ... would you mind taking a quick look?

Thanks!

ATB, Ramsay Jones

Next: Junio C Hamano
Message 1 of 6 in “t9000-addresses.sh: unexpected pases”
  1. Ramsay JonesOct 21, 2016
  2. Junio C HamanoOct 21, 2016
  3. 1/2 t9000-addresses: update expected results after fixMatthieu Moy, Oct 21, 2016
  4. 2/2 Git.pm: add comment pointing to t9000Matthieu Moy, Oct 21, 2016
  5. Junio C HamanoOct 21, 2016
  6. Ramsay JonesOct 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.