git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] Git.pm: add comment pointing to t9000

From
Matthieu Moy <matthieu.moy@imag.fr>
Date
Oct 21, 2016, 09:20 UTC
Message-ID
<20161021092024.15861-2-Matthieu.Moy@imag.fr>
In-Reply-To
<20161021092024.15861-1-Matthieu.Moy@imag.fr>

parse_mailboxes should probably eventually be completely equivalent to Mail::Address, and if this happens we can drop the Mail::Address dependency. Add a comment in the code reminding the current state of the code, and point to the corresponding failing test to help future contributors to get it right.

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 perl/Git.pm | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/perl/Git.pm b/perl/Git.pm
index 42e0895ef7..8bb2b7c7e3 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -870,6 +870,8 @@ Return an array of mailboxes extracted from a string.
 
 =cut
 
+# Very close to Mail::Address's parser, but we still have minor
+# differences in some cases (see t9000 for examples).
 sub parse_mailboxes {
 	my $re_comment = qr/\((?:[^)]*)\)/;
 	my $re_quote = qr/"(?:[^\"\\]|\\.)*"/;
-- 
2.10.1.651.gffd0de0
Previous: Matthieu MoyNext: Junio C Hamano
Message 4 of 6 in “t9000-addresses.sh: unexpected pases”
  1. Ramsay JonesOct 21, 2016
  2. Junio C HamanoOct 21, 2016
  3. 1/2 t9000-addresses: update expected results after fixMatthieu Moy, Oct 21, 2016
  4. 2/2 Git.pm: add comment pointing to t9000Matthieu Moy, Oct 21, 2016
  5. Junio C HamanoOct 21, 2016
  6. Ramsay JonesOct 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.