git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] show-ref: Allow --head to work with --verify

From
Vladimir Panteleev <thecybershadow@gmail.com>
Date
Jan 20, 2017, 22:55 UTC
Message-ID
<3b1d2717-dd7f-2add-b935-3ace6063b258@gmail.com>
In-Reply-To
<xmqqa8aly2o4.fsf@gitster.mtv.corp.google.com>
On 2017-01-20 19:03, Junio C Hamano wrote:
> and viewed in the wider context, I notice that quiet is not honored
> in the added code.  I think that is easily fixable by replacing this
> hunk with something like:

--quiet will still work correctly with the current patch, because show_ref already checks quiet. Granted, the original --verify code used show_one and not show_ref; however, I don't see a meaningful difference between calling show_ref and show_one for HEAD, other than a bit of overhead, so adding a new function may not be worthwhile. I will still add tests for this; however, in light of this, would you still like me to perform the change you requested?

-- 
Best regards,
  Vladimir
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 11 in “show-ref: Allow --head to work with --verify”
  1. show-ref: Allow --head to work with --verifyVladimir Panteleev, Jan 20, 2017
  2. Junio C HamanoJan 20, 2017
  3. Vladimir PanteleevJan 20, 2017
  4. Vladimir PanteleevJan 20, 2017
  5. Junio C HamanoJan 20, 2017
  6. Junio C HamanoJan 20, 2017
  7. Junio C HamanoJan 20, 2017
  8. Vladimir PanteleevJan 20, 2017
  9. Junio C HamanoJan 20, 2017
  10. Junio C HamanoJan 20, 2017
  11. Vladimir PanteleevJan 21, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.