From: Vladimir Panteleev <thecybershadow@gmail.com>
Date: Fri, 20 Jan 2017 22:55:12 GMT
Subject: Re: [PATCH] show-ref: Allow --head to work with --verify
Message-ID: <3b1d2717-dd7f-2add-b935-3ace6063b258@gmail.com>
In-Reply-To: <xmqqa8aly2o4.fsf@gitster.mtv.corp.google.com>

On 2017-01-20 19:03, Junio C Hamano wrote:
> and viewed in the wider context, I notice that quiet is not honored
> in the added code.  I think that is easily fixable by replacing this
> hunk with something like:

--quiet will still work correctly with the current patch, because 
show_ref already checks quiet. Granted, the original --verify code used 
show_one and not show_ref; however, I don't see a meaningful difference 
between calling show_ref and show_one for HEAD, other than a bit of 
overhead, so adding a new function may not be worthwhile. I will still 
add tests for this; however, in light of this, would you still like me 
to perform the change you requested?

-- 
Best regards,
  Vladimir