Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error
Thanks a lot for taking care of this!
- Lars
On 22 Sep 2015, at 21:17, Junio C Hamano <gitster@pobox.com> wrote:
Show 28 quoted lines
> Yup, this was privately reported and I just squashed a fix in right now ;-)
>
> Thanks. "cd t && make test-lint" would have caught it.
>
> On Tue, Sep 22, 2015 at 12:11 PM, Michael Blume <blume.mike@gmail.com> wrote:
>> I'm seeing test failures
>>
>> non-executable tests: t9825-git-p4-handle-utf16-without-bom.sh
>>
>> ls -l shows that all the other tests are executable but t9825 isn't.
>>
>> On Tue, Sep 22, 2015 at 9:02 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Lars Schneider <larsxschneider@gmail.com> writes:
>>>
>>>> This works.
>>>
>>> OK, and thanks; as I don't do perforce, the squash was without any
>>> testing.
>>>
>>>> Do we need the “-e” option?
>>>
>>> In syntactic sense, no, but our codebase tends to prefer to have
>>> one, because it is easier to spot which ones are the instructions if
>>> you consistently have "-e" even when you give only one.
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe git" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
Lars Schneider <larsxschneider@gmail.com>