From: Lars Schneider Date: Wed, 23 Sep 2015 07:34:37 GMT Subject: Re: [PATCH v4 1/2] git-p4: add test case for "Translation of file content failed" error Message-ID: <3E330347-0F89-4E6F-8663-694AD3A559CC@gmail.com> In-Reply-To: Thanks a lot for taking care of this! - Lars On 22 Sep 2015, at 21:17, Junio C Hamano wrote: > Yup, this was privately reported and I just squashed a fix in right now ;-) > > Thanks. "cd t && make test-lint" would have caught it. > > On Tue, Sep 22, 2015 at 12:11 PM, Michael Blume wrote: >> I'm seeing test failures >> >> non-executable tests: t9825-git-p4-handle-utf16-without-bom.sh >> >> ls -l shows that all the other tests are executable but t9825 isn't. >> >> On Tue, Sep 22, 2015 at 9:02 AM, Junio C Hamano wrote: >>> Lars Schneider writes: >>> >>>> This works. >>> >>> OK, and thanks; as I don't do perforce, the squash was without any >>> testing. >>> >>>> Do we need the “-e” option? >>> >>> In syntactic sense, no, but our codebase tends to prefer to have >>> one, because it is easier to spot which ones are the instructions if >>> you consistently have "-e" even when you give only one. >>> -- >>> To unsubscribe from this list: send the line "unsubscribe git" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html