Re: What's cooking in git.git (Mar 2018, #01; Thu, 1)
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Mar 2, 2018, 17:39 UTC
- Message-ID
- <3C32011B-30E5-4E63-8692-5D598430DC99@gmail.com>
- In-Reply-To
- <xmqqsh9icsh1.fsf@gitster-ct.c.googlers.com>
Show 27 quoted lines
> On 02 Mar 2018, at 18:11, Junio C Hamano <gitster@pobox.com> wrote: > > Junio C Hamano <gitster@pobox.com> writes: > >> SZEDER Gábor <szeder.dev@gmail.com> writes: >> >>> On Thu, Mar 1, 2018 at 11:20 PM, Junio C Hamano <gitster@pobox.com> wrote: >>> >>>> * sg/travis-build-during-script-phase (2018-01-08) 1 commit >>>> - travis-ci: build Git during the 'script' phase >>>> >>>> Stalled for too long without any response; will discard. >>> >>> I still think this is a good change as-is and it does make checking the >>> results of Travis CI builds easier. The issue Lars raised in [1] is in >>> my opinion a non-issue [2] in practice and Lars hasn't yet disagreed >>> with that. >> >> OK, so I simply misread the discussion and did not realize that it >> reached a conclusion? If that's the case, good ;-). Thanks. > > OK, I think I now understand what happened. I misread the "fold" > discussion and thought we were still exploring the possibility, to > avoid showing uninteresting zero-status case to the users. > > If we do not care about that part, then it seems that the discussion > thread is complete. Let's move on.
All good with me. I just wanted explain my reasoning for the initial implementation. I do understand Szeder's reasoning too and I am OK with the change.
Thanks for improving the TravisCI integration Szeder!
- Lars