git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] reftable: ignore file-in-use errors when unlink(3p) fails on Windows

From
Johannes Sixt <j6t@kdbg.org>
Date
Jan 29, 2025, 07:40 UTC
Message-ID
<37c14379-68e4-4c52-a08d-b78c7797ef26@kdbg.org>
In-Reply-To
<Z5iEcjJpUI3spSrB@pks.im>
Am 28.01.25 um 08:17 schrieb Patrick Steinhardt:
Show 15 quoted lines
> On Tue, Jan 28, 2025 at 07:52:48AM +0100, Johannes Sixt wrote:
>> The interactive question is only useful when the user has control over
>> an uncooperative process that keeps a file open for an extended time and
>> can find that processes, which is either obvious or extremely difficult.
>> As I said, I haven't seen the question since a long, long time now, but
>> I am also the first to admit that my way of using Git is rather narrow.
> 
> That would be a much wider change compared to what I'm proposing though.
> I don't quite feel comfortable with pushing for such a change as I don't
> have enough of a stake in Windows to be able to judge whether it would
> be sensible or not.
> 
> If Dscho confirms your take I'm happy to do so. But otherwise I'd prefer
> to continue with the more limited scope, as I know that the behaviour is
> unexpected and unnecessary in the reftable library.

I can live with the narrow workaround that you proposed. A more thorough rewrite like I propose would have to cook for quite some time before it can be released to the general public.

-- Hannes
Previous: Patrick SteinhardtNext: Christian Reich
Message 8 of 16 in “reftable: ignore file-in-use errors when unlink(3p) fails on Windows”
  1. reftable: ignore file-in-use errors when unlink(3p) fails on WindowsPatrick Steinhardt, Jan 25, 2025
  2. Johannes SixtJan 25, 2025
  3. Patrick SteinhardtJan 25, 2025
  4. Johannes SixtJan 25, 2025
  5. Patrick SteinhardtJan 27, 2025
  6. Johannes SixtJan 28, 2025
  7. Patrick SteinhardtJan 28, 2025
  8. Johannes SixtJan 29, 2025
  9. Christian ReichJan 25, 2025
  10. Patrick SteinhardtJan 27, 2025
  11. Junio C HamanoJan 26, 2025
  12. Patrick SteinhardtJan 27, 2025
  13. reftable: ignore file-in-use errors when unlink(3p) fails on WindowsPatrick Steinhardt, Feb 6, 2025
  14. Christian ReichMar 14, 2025
  15. Patrick SteinhardtMar 14, 2025
  16. Johannes SchindelinMar 15, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.