From: Johannes Sixt <j6t@kdbg.org>
Date: Wed, 29 Jan 2025 07:40:09 GMT
Subject: Re: [PATCH] reftable: ignore file-in-use errors when unlink(3p) fails on Windows
Message-ID: <37c14379-68e4-4c52-a08d-b78c7797ef26@kdbg.org>
In-Reply-To: <Z5iEcjJpUI3spSrB@pks.im>

Am 28.01.25 um 08:17 schrieb Patrick Steinhardt:
> On Tue, Jan 28, 2025 at 07:52:48AM +0100, Johannes Sixt wrote:
>> The interactive question is only useful when the user has control over
>> an uncooperative process that keeps a file open for an extended time and
>> can find that processes, which is either obvious or extremely difficult.
>> As I said, I haven't seen the question since a long, long time now, but
>> I am also the first to admit that my way of using Git is rather narrow.
> 
> That would be a much wider change compared to what I'm proposing though.
> I don't quite feel comfortable with pushing for such a change as I don't
> have enough of a stake in Windows to be able to judge whether it would
> be sensible or not.
> 
> If Dscho confirms your take I'm happy to do so. But otherwise I'd prefer
> to continue with the more limited scope, as I know that the behaviour is
> unexpected and unnecessary in the reftable library.

I can live with the narrow workaround that you proposed. A more thorough
rewrite like I propose would have to cook for quite some time before it
can be released to the general public.

-- Hannes