Re: [TopGit PATCH] hooks/pre-commit.sh: fix it again
- From
Bert Wesarg <bert.wesarg@googlemail.com>
- Date
- Mar 25, 2009, 12:24 UTC
- Message-ID
- <36ca99e90903250524g3549b629g8ce1947f741878f7@mail.gmail.com>
- In-Reply-To
- <20090325122027.GB30873@pengutronix.de>
2009/3/25 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
Show 6 quoted lines
> On Wed, Mar 25, 2009 at 12:43:04PM +0100, Bert Wesarg wrote: >> First I think the '#' is a leftover, second this is now a bashism. > according to bash(1): > > If pattern begins with #, it must match at the beginning of the > expanded value of parameter.
That is obviously true, I first removed this # and than switch to bash (after it stills failed), so this was just thinking not testing.
Show 5 quoted lines
> > And I noticed, too, that this is a bashism. Using dash it fails, even > with your patch. > > I would prefer to really fix it now.
Thanks. I intended this patch as a bug report.
Bert
Show 8 quoted lines
> > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | http://www.pengutronix.de/ | >