git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [TopGit PATCH] hooks/pre-commit.sh: fix it again

From
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date
Mar 25, 2009, 12:20 UTC
Message-ID
<20090325122027.GB30873@pengutronix.de>
In-Reply-To
<1237981384-7857-1-git-send-email-bert.wesarg@googlemail.com>
On Wed, Mar 25, 2009 at 12:43:04PM +0100, Bert Wesarg wrote:
> First I think the '#' is a leftover, second this is now a bashism.
according to bash(1):
	If pattern begins with #, it must match at the beginning of the
	expanded value of parameter.

And I noticed, too, that this is a bashism. Using dash it fails, even with your patch.

I would prefer to really fix it now.

Best regards Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
Previous: martin f krafftNext: Bert Wesarg
Message 3 of 8 in “hooks/pre-commit.sh: fix it again”
  1. hooks/pre-commit.sh: fix it againBert Wesarg, Mar 25, 2009
  2. martin f krafftMar 25, 2009
  3. Uwe Kleine-KönigMar 25, 2009
  4. Bert WesargMar 25, 2009
  5. Uwe Kleine-KönigMar 25, 2009
  6. hooks/pre-commit.sh: fix bashismUwe Kleine-König, Mar 26, 2009
  7. Marc Kleine-BuddeMar 26, 2009
  8. Bert WesargMar 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.