Re: [TopGit PATCH] tg-tred: Print the transitive reduction of the dependecies

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Mar 25, 2009, 11:20 UTC
Message-ID: <36ca99e90903250420l42a46718x91263b4adb7da45f@mail.gmail.com>
In-Reply-To: <20090325105841.GB27803@pengutronix.de>

2009/3/25 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:

Show 31 quoted lines

> Hello,
>
> On Wed, Mar 25, 2009 at 11:35:41AM +0100, Bert Wesarg wrote:
>> +$tg summary --graphviz |
>> +     tred |
>> +     gvpr -a "\"${name}\"" '
>> +BEG_G {
>> +    node_t  ctr;
>> +    edge_t  e;
>> +
>> +    ctr = isNode($, ARGV[0]);
>> +    for (e = fstedge(ctr); e; e = nxtedge(e,ctr)) {
>> +        if (e.head.name != ARGV[0])
>> +            printf("%s\n", e.head.name);
>> +    }
>> +    exit(0);
>> +}
> I don't know tred and gvpr, just looked shortly over the manpages.
> Anyhow what I consider important is that the order of .topdeps is
> stable.  That is
>
>        t/topic1
>        master
>        t/topic2
>
> must not be rewritten to
>
>        t/topic2
>        t/topic1
>
> if master is redundant.  Is this asserted?

I asked this myself, I haven't looked very deeply but I think it is stable. And some tests showed this.

>
> And note that I intend to change the semantic of tg summary s.t. it only
> recurses on the current branch instead of all branches.  I think this
> doesn't hurt here, though.

I don't understand and can't confirm this. tg summary calls 'git for-each-ref refs/top-bases' so all TopGit controlled branches should be reached.

While I was adding a 'reduce' subcommand to tg-depend (which calls tg-tred and updates .topdeps) I saw that it is immposible to add a none TopGit controlled branch to the dependency list, which looks wrong. Dependencies don't need to be TopGit controlled, like master.

Bert

>
> Best regards and thanks for your contribution,
> Uwe