Re: [TopGit PATCH] tg-tred: Print the transitive reduction of the dependecies

From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Mar 25, 2009, 10:58 UTC
Message-ID: <20090325105841.GB27803@pengutronix.de>
In-Reply-To: <1237977341-32173-1-git-send-email-bert.wesarg@googlemail.com>

Hello,

On Wed, Mar 25, 2009 at 11:35:41AM +0100, Bert Wesarg wrote:

Show 14 quoted lines

> +$tg summary --graphviz |
> +	tred |
> +	gvpr -a "\"${name}\"" '
> +BEG_G {
> +    node_t  ctr;
> +    edge_t  e;
> +
> +    ctr = isNode($, ARGV[0]);
> +    for (e = fstedge(ctr); e; e = nxtedge(e,ctr)) {
> +        if (e.head.name != ARGV[0])
> +            printf("%s\n", e.head.name);
> +    }
> +    exit(0);
> +}

I don't know tred and gvpr, just looked shortly over the manpages. Anyhow what I consider important is that the order of .topdeps is stable. That is

	t/topic1
	master
	t/topic2

must not be rewritten to

	t/topic2
	t/topic1

if master is redundant.  Is this asserted?

Moreover I wonder if the gvpr program could be optimized when E is used instead of BEG_G, but as I said above, I don't know how gvpr works.

And note that I intend to change the semantic of tg summary s.t. it only recurses on the current branch instead of all branches. I think this doesn't hurt here, though.

Best regards and thanks for your contribution, Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |