Re: [TopGit PATCH] tg.sh: Check for read permissions of help files

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Aug 9, 2008, 07:35 UTC
Message-ID: <36ca99e90808090035r6331a118k5a26486de1acf002@mail.gmail.com>
In-Reply-To: <1218009771-30358-1-git-send-email-bert.wesarg@googlemail.com>

Petr,

On Wed, Aug 6, 2008 at 10:02, Bert Wesarg <bert.wesarg@googlemail.com> wrote:

> -       elif [ -f "@sharedir@/tg-$1.txt" ] ; then
> +       elif [ -f "@sharedir@/tg-$1.txt" -a -r "@sharedir@/tg-$1.txt" ] ; then

I saw your simplified commit for this, but you should know, that '-r' tests only for read permissions, not for a regular file, so this test succeed also for a pipe/socket for which do you have read permissions.

Bert

Show 6 quoted lines

>                cat "@sharedir@/tg-$1.txt"
>        else
>                echo "`basename $0`: no help for $1" 1>&2
> --
> tg: (e311d15..) t/check-read-permissions-of-help-files (depends on: master)
>